Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify -all documentation #268

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Clarify -all documentation #268

merged 1 commit into from
Jun 2, 2022

Conversation

heaths
Copy link
Member

@heaths heaths commented May 24, 2022

Supersedes #265. Also fixes incompatible build flags for debug.

Supersedes microsoft#265. Also fixes incompatible build flags for debug.
@heaths
Copy link
Member Author

heaths commented May 25, 2022

Since the .rc file is treated as a binary (I've tried to fix this in the past, but changing the encoding to something VS/VC++ likes that also doesn't mess up git wasn't working), this is the wording change for -all:

- Finds all instances even if they are incomplete and may not launch.
+ Finds instances in complete, launchable, and incomplete states. By default, only instances in a complete state - no errors or reboot required - are searched.

Mainly, make it clear that this doesn't mean all products or all releases. We can't change the behavior lest we break compatibility for untold numbers of CIs.

@heaths heaths merged commit 4524772 into microsoft:master Jun 2, 2022
@heaths heaths deleted the all-docs branch June 2, 2022 03:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants